Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Saleor 1775 thumbnail size issues #959

Merged
merged 7 commits into from
Dec 5, 2020

Conversation

MarekChoinski
Copy link
Contributor

I want to merge this change because it:

  • fixes product gallery preview height
  • fixes thumbnail preview height on Order history
  • fixes thumbnail height on listing of products

Screenshots

image

image

image

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to saleor-1775-thumbnail-size-issues December 1, 2020 14:21 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1775-thumbnail-size-issues December 1, 2020 14:21 Inactive
@patrys
Copy link
Member

patrys commented Dec 1, 2020

Task linked: SALEOR-1775 Thumbnail size issues

@github-actions github-actions bot temporarily deployed to saleor-1775-thumbnail-size-issues December 1, 2020 14:34 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1775-thumbnail-size-issues December 1, 2020 14:34 Inactive
@krzysztofwolski
Copy link
Member

@MarekChoinski gallery has issue with sizes too https://saleor-1775-thumbnail-size-issues.storefront.saleor.rocks/product/aaaa-sku/498/
Can you fix that as well?

@MarekChoinski
Copy link
Contributor Author

@krzysztofwolski Issue you mentioned is already solved

@github-actions github-actions bot temporarily deployed to saleor-1775-thumbnail-size-issues December 2, 2020 00:04 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1775-thumbnail-size-issues December 2, 2020 00:04 Inactive
@MarekChoinski MarekChoinski force-pushed the SALEOR-1775-thumbnail-size-issues branch from 74887ee to da8f83a Compare December 2, 2020 11:27
@github-actions github-actions bot temporarily deployed to saleor-1775-thumbnail-size-issues December 2, 2020 11:28 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1775-thumbnail-size-issues December 2, 2020 11:28 Inactive
@krzysztofwolski krzysztofwolski merged commit 6fd7b46 into master Dec 5, 2020
@krzysztofwolski krzysztofwolski deleted the SALEOR-1775-thumbnail-size-issues branch December 5, 2020 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants