Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Drop ProductVariant.isAvailable field #965

Merged
merged 5 commits into from
Dec 17, 2020
Merged

Drop ProductVariant.isAvailable field #965

merged 5 commits into from
Dec 17, 2020

Conversation

maarcingebala
Copy link
Member

@maarcingebala maarcingebala commented Dec 10, 2020 •
edited
Loading

This PR removes the deprecated ProductVariant.isAvailable field.

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to drop-deprecated-quantity-fields December 10, 2020 15:15 Inactive
@github-actions github-actions bot had a problem deploying to storybook drop-deprecated-quantity-fields December 10, 2020 15:15 Failure
@maarcingebala
Copy link
Member Author

Should be merged with:

@patrys
Copy link
Member

patrys commented Dec 10, 2020

Task linked: SALEOR-213 Update product variant availability check

@github-actions github-actions bot temporarily deployed to drop-deprecated-quantity-fields December 11, 2020 12:54 Inactive
@github-actions github-actions bot had a problem deploying to storybook drop-deprecated-quantity-fields December 11, 2020 12:54 Failure
@github-actions github-actions bot temporarily deployed to drop-deprecated-quantity-fields December 15, 2020 09:45 Inactive
@github-actions github-actions bot temporarily deployed to storybook drop-deprecated-quantity-fields December 15, 2020 09:45 Inactive
fowczarek
fowczarek approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@fowczarek fowczarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog ?

@github-actions github-actions bot temporarily deployed to drop-deprecated-quantity-fields December 15, 2020 14:49 Inactive
@github-actions github-actions bot temporarily deployed to storybook drop-deprecated-quantity-fields December 15, 2020 14:49 Inactive
@github-actions github-actions bot temporarily deployed to drop-deprecated-quantity-fields December 17, 2020 08:33 Inactive
@maarcingebala maarcingebala merged commit c4fc4e3 into master Dec 17, 2020
@maarcingebala maarcingebala deleted the drop-deprecated-quantity-fields branch December 17, 2020 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@orzechdev orzechdev orzechdev approved these changes

@bmigirl bmigirl bmigirl approved these changes

@fowczarek fowczarek fowczarek approved these changes

@krzysztofwolski krzysztofwolski Awaiting requested review from krzysztofwolski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maarcingebala @patrys @orzechdev @bmigirl @fowczarek