This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
Add support for node LTS to build #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omgaz
changed the title
|
Is there a reason this has not been merged? |
|
@manivinesh, you're the last committer in this repo - any updates on getting this (or the lodash security upgrade PR) merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As NodeJS v8 has fallen out of maintenance mode I think it's important to keep testing against the current LTS versions 10 and 12.
Also, the updated to the recommended way of testing against the NodeJS stable using just
node.Would be nice to see a deprecation of NodeJS v6 ASAP and a plan to remove NodeJS v8 in the coming months.