True promise OR callback refactor

[vernak2539]

• updated auth client
• refactored promise integration
• added/updated tests
• slimmed dependencies

[dougwilson]

Looks like the failure is from a missing dependency.

[vernak2539]

Yep, hopefully the new push works

[vernak2539]

@dougwilson all the tests are passing. mind taking a look?

Future work will include refactoring the tests and such, but I think they've been modified in the correct way, and I've tested a few scenarios.

[dougwilson]

Changes seem fine to me.

[dougwilson]

Because this used to technically always return a promise, even if a callback was provided, I'm leaning towards releasing this as 2.0.0. It'll match fuel-auth as well. @vernak2539

[vernak2539]

Sounds close enough to a breaking change. Go for it
On Thu, 5 Nov 2015 at 02:19, Douglas Christopher Wilson <
notifications@github.com> wrote:

Because this used to technically always return a promise, even if a
callback was provided, I'm leaning towards releasing this as 2.0.0. It'll
match fuel-auth as well. @vernak2539 https://github.com/vernak2539

—
Reply to this email directly or view it on GitHub
#62 (comment)
.