Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

covert to multi-root workspace #122

Merged
merged 1 commit into from
Aug 26, 2024
Merged

covert to multi-root workspace #122

merged 1 commit into from
Aug 26, 2024

Conversation

lonhutt
Copy link
Contributor

@lonhutt lonhutt commented Aug 19, 2024

Changes:

  • Added support for both multi and single root workspaces
  • Added a convert to multi-root workspace command

Copy link

github-actions bot commented Aug 19, 2024

Test Results

 2 files  ±0   2 suites  ±0   1d 2h 36m 10s ⏱️ - 2h 43m 29s
 7 tests ±0   7 ✅ ±0  0 💤 ±0  0 ❌ ±0 
14 runs  ±0  14 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d11617e. ± Comparison against base commit b72ae4a.

♻️ This comment has been updated with latest results.

@guw
Copy link
Collaborator

guw commented Aug 20, 2024

@lonhutt It looks like this is enforcing multi-root for everyone know. We shouldn't be doing this. Single root is working quite nicely for the smaller projects (including the Java language server extension itself).

Can you rework so it supports both?

src/extension.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@lonhutt lonhutt force-pushed the lhutt/switch_to_multiroot branch 2 times, most recently from e4fba45 to bfa9268 Compare August 20, 2024 20:03
src/extension.ts Outdated Show resolved Hide resolved
@lonhutt lonhutt force-pushed the lhutt/switch_to_multiroot branch 3 times, most recently from 4619ab0 to ee9c320 Compare August 20, 2024 20:27
@lonhutt lonhutt self-assigned this Aug 21, 2024
@lonhutt lonhutt merged commit 5e22ac9 into main Aug 26, 2024
7 checks passed
@lonhutt lonhutt deleted the lhutt/switch_to_multiroot branch August 26, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants