Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multi-root file viewer #124

Merged
merged 1 commit into from
Oct 2, 2024
Merged

add multi-root file viewer #124

merged 1 commit into from
Oct 2, 2024

Conversation

lonhutt
Copy link
Contributor

@lonhutt lonhutt commented Sep 17, 2024

Added root level file only viewer when in multi-root mode.

Needed a nice way to open/interact with files stored in the project root when that folder was not rendered in the main explorer view.

Screenshot 2024-09-17 at 10 54 34 AM

Copy link

github-actions bot commented Sep 17, 2024

Test Results

 2 files  ±0   2 suites  ±0   1d 2h 0m 56s ⏱️ - 2h 56m 47s
 7 tests ±0   7 ✅ ±0  0 💤 ±0  0 ❌ ±0 
14 runs  ±0  14 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit bbd13b8. ± Comparison against base commit 4f12bc1.

♻️ This comment has been updated with latest results.

@lonhutt lonhutt marked this pull request as ready for review September 17, 2024 20:45
@guw
Copy link
Collaborator

guw commented Sep 18, 2024

@lonhutt Although it looks nice and useful I can see a conflict when you are working with multiple Bazel workspaces. Which one would it show?

Wouldn't it be better if there is a check in the background and a command for easily importing/adding a project for the workspace root into the multi-root setup? That seems more flexible than a second view.

Also I am seldomly using the views on the lower left. I really just focus on the file explorer and would expect the things be visible there.

@lonhutt
Copy link
Contributor Author

lonhutt commented Sep 19, 2024

@guw The idea here was to provide a simple way for users, when in a multi-root workspace, to view/open files like WORKSPACE, package.json, .buildifier.json, etc without having to include the full project root.

I think adding a 'import project' feature and improving the multi-root workspace management features is a really good idea, but not the purpose of this PR.

The alternative to this approach would be to create a separate folder in some other location (user.home?) and symlink in all the files stored at the root of the project.

As for the situation where multiple bazel projects are included in the workspace; do you mean the workspace would include only sub-modules from two or more bazel projects, or would you expect multiple bazel projects be included in their entirety, or do you expect submodules from one to be included alongside a complete/separate bazel project?

package.json Outdated Show resolved Hide resolved
b4Kcases

This comment was marked as duplicate.

@lonhutt lonhutt merged commit be4c6d4 into main Oct 2, 2024
7 checks passed
@lonhutt lonhutt deleted the add_multiroot_file_viewer branch October 2, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants