-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add multi-root file viewer #124
Conversation
e5b9347
to
679e1ca
Compare
@lonhutt Although it looks nice and useful I can see a conflict when you are working with multiple Bazel workspaces. Which one would it show? Wouldn't it be better if there is a check in the background and a command for easily importing/adding a project for the workspace root into the multi-root setup? That seems more flexible than a second view. Also I am seldomly using the views on the lower left. I really just focus on the file explorer and would expect the things be visible there. |
@guw The idea here was to provide a simple way for users, when in a multi-root workspace, to view/open files like I think adding a 'import project' feature and improving the multi-root workspace management features is a really good idea, but not the purpose of this PR. The alternative to this approach would be to create a separate folder in some other location (user.home?) and symlink in all the files stored at the root of the project. As for the situation where multiple bazel projects are included in the workspace; do you mean the workspace would include only sub-modules from two or more bazel projects, or would you expect multiple bazel projects be included in their entirety, or do you expect submodules from one to be included alongside a complete/separate bazel project? |
679e1ca
to
e765623
Compare
e765623
to
bbd13b8
Compare
Added root level file only viewer when in multi-root mode.
Needed a nice way to open/interact with files stored in the project root when that folder was not rendered in the main explorer view.