Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix circle ci publishing #73

Merged
merged 3 commits into from
Nov 1, 2021
Merged

chore: fix circle ci publishing #73

merged 3 commits into from
Nov 1, 2021

Conversation

nolanlawson
Copy link
Contributor

@nolanlawson nolanlawson commented Nov 1, 2021

I'm not sure why 1.1.4 was a botched release, but it looks like the dist/ files weren't copied from the test job to the deploy job. This adds an extra save_workspace which I'm hoping will fix it?

If not, I added a check that will fail if there isn't a dist/ JS file to publish. In that case, we can just publish manually.

.circleci/config.yml Outdated Show resolved Hide resolved
@nolanlawson
Copy link
Contributor Author

Alternatively, we could just rebuild the files all over again

@nolanlawson
Copy link
Contributor Author

According to the Circle CI docs, this should have worked, so I have no idea what went wrong.

The workspace is additive only, jobs may add files to the workspace but cannot delete files from the workspace. Each job can only see content added to the workspace by the jobs that are upstream of it. When attaching a workspace the “layer” from each upstream job is applied in the order the upstream jobs appear in the workflow graph.

@nolanlawson
Copy link
Contributor Author

Looking back, the deploy job has never run successfully.

@nolanlawson
Copy link
Contributor Author

I think I figured it out: the package.json didn't have a prepare script, so actually we were never running yarn build anywhere in the pipeline! The test scripts could run just fine using source TS files.

I added a prepare script; 🤞 let's hope it works.

@nolanlawson nolanlawson changed the title chore: try to fix circle ci publishing chore: fix circle ci publishing Nov 1, 2021
.circleci/config.yml Outdated Show resolved Hide resolved
@nolanlawson nolanlawson merged commit baa0706 into master Nov 1, 2021
@pmdartus pmdartus deleted the nolan/fix-publish-2 branch November 2, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants