feat: add recordPicker stubs #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamiNoufal
suggested changes
Jul 5, 2023
| @api variant; | ||
| @api checkValidity() {} | ||
| @api reportValidity() {} | ||
| @api setCustomValidity() {} |
There was a problem hiding this comment.
Good point, those methods were not on the stub in the lightning-components repo 🤦
There was a problem hiding this comment.
Update: focus and blur methods are not added to the stub when re-generating stubs on the lightning-components repo. It seems they are not necessary (they're not on other components stubs either).
There was a problem hiding this comment.
Native method are not needed it seems according to LBC https://github.com/salesforce-experience-platform-emu/lightning-components/blob/ma[…]/lightning-components-stubs/scripts/generate-lightning-mocks.js
RamiNoufal
approved these changes
Jul 5, 2023
ravijayaramappa
approved these changes
Jul 5, 2023
thomasFoulon
deleted the
search-lookups/record-picker/add-recordPicker-stubs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing lightning-record-picker stub for testing.