fix: update dependencies, including jest #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should probably be tested on a sample project before merging. I just tried it on a small project and it immediately failed due to an issue with |
nolanlawson
commented
Aug 10, 2023
| function red(message) { | ||
| // equivalent to chalk.red() | ||
| return `\x1B[31m${message}\x1B[39m`; | ||
| } |
There was a problem hiding this comment.
chalk has breaking changes, and we don't need it.
|
OK, I tested I also tested |
ekashida
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Jest updated from v27 to v28
Fixes #319
Updates all dependencies, including Jest. Users of
sfdx-lwc-jestmay need to modify their tests to deal with breaking changes in Jest 28 and Jest 29.