Add IngredientIndex to KeyStruct #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
MichaReiser
reviewed
Oct 12, 2024
nikomatsakis
requested changes
Oct 15, 2024
CodSpeed Performance ReportMerging #591 will not alter performanceComparing Summary
|
puuuuh
force-pushed
the
typeid_mismatch_fix
branch
3 times, most recently
from
4bcbfee to
47c318f
Compare
puuuuh
force-pushed
the
typeid_mismatch_fix
branch
from
47c318f to
acae02d
Compare
nikomatsakis
requested changes
Oct 16, 2024
src/tracked_struct.rs
Outdated
| /// allowing for multiple tracked structs with the same hash and ingredient_index | ||
| /// created within the query to each have a unique id. | ||
| #[derive(Debug, PartialEq, Eq, Hash, PartialOrd, Ord, Copy, Clone)] | ||
| pub struct DisambiguationKey { |
There was a problem hiding this comment.
It seems to me that the naming of DisambiguationKey is not ideal, given e.g. KeyStruct. I'd like some names that make the relationship clearer. Here are some possibilities -- hopefully it's clear which is meant to be which in each case!
HashStructandKeyStruct(close to today)IdentityHashandIdentityIdentityHashandDisambiguatedIdentityHashIngredientAndHashandDisambiguatorIngredientAndHash(just name it after the contents)
What do you think @puuuuh?
There was a problem hiding this comment.
IdentityHash and Identity is the best variant, imo
There was a problem hiding this comment.
Also something like IdentityHash-StructCompoundId?
nikomatsakis
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #590