Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: pass db_lt to the inner_fn #617

Closed

Conversation

davidbarsky
Copy link
Contributor

This is necessary to support passing interned structs to queries in the query group imitation macro: https://github.com/davidbarsky/db-ext-macro/.

(I'll upstream that macro to Salsa, promise! The code quality is bad, however...)

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit c2ce00d
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/673f52634bc1cb0008bad837

Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #617 will not alter performance

Comparing davidbarsky:david/pass-db-lt-to-inner-fn (c2ce00d) with master (32f8ee9)

Summary

✅ 8 untouched benchmarks

Copy link
Contributor

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add demonstrating its use case?

@davidbarsky davidbarsky force-pushed the david/pass-db-lt-to-inner-fn branch from eda95bd to 4b674d5 Compare November 20, 2024 16:12
@davidbarsky
Copy link
Contributor Author

Pushed a fix for the unused lifetime lint.

Could you add demonstrating its use case?

@MichaReiser Uh, probably. Without porting my macro over, it might be a little challenging, but I think I can add it as a desugared version.

@davidbarsky davidbarsky force-pushed the david/pass-db-lt-to-inner-fn branch from 4b674d5 to c2ce00d Compare November 21, 2024 15:31
@davidbarsky
Copy link
Contributor Author

Closing this, as this isn't needed anymore.

@davidbarsky davidbarsky deleted the david/pass-db-lt-to-inner-fn branch December 18, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants