Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Rails 8 #168

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Add support for Rails 8 #168

merged 4 commits into from
Nov 26, 2024

Conversation

rjstorres
Copy link
Contributor

Add support for Rails 8, with activesupport and activemodel gems bump to version '~> 8.0.0'

@rjstorres rjstorres requested review from jturkel and a team as code owners November 22, 2024 17:48
@rjstorres rjstorres added the No Changelog Needed Allow merges without CHANGELOG.md updates. label Nov 22, 2024
erikkessler1
erikkessler1 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@erikkessler1 erikkessler1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did you want to bump the version and update the CHANGELOG so you get a new release?

@rjstorres
Copy link
Contributor Author

Looks good. Did you want to bump the version and update the CHANGELOG so you get a new release?

Yes. please.

@erikkessler1
Copy link
Contributor

Cool, you should feel free to change this line to 5.2.0:

avromatic/lib/avromatic/version.rb

Line 4 in 51e56e8

VERSION = '5.1.1'

And then add a - Added support for Rails 8.0 line to the CHANGELOG.md

@rjstorres rjstorres removed the No Changelog Needed Allow merges without CHANGELOG.md updates. label Nov 26, 2024
@rjstorres rjstorres merged commit 0700054 into master Nov 26, 2024
3 checks passed
@rjstorres rjstorres deleted the update-rails-deps-to-8 branch November 26, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikkessler1 erikkessler1 erikkessler1 approved these changes

@jturkel jturkel Awaiting requested review from jturkel jturkel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjstorres @erikkessler1