Add support for logical types #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }.freeze | ||
|
|
||
| def self.value_class(logical_type) | ||
| LOGICAL_TYPE_MAP.fetch(logical_type, nil) |
There was a problem hiding this comment.
This could probably just be LOGICAL_TYPE_MAP[logical_type] since you're falling back to nil anyway.
There was a problem hiding this comment.
For some reason when I wrote this this felt like it captured more explicitly that its okay for a logical type to not be present, and we're expecting to handle nil. But I don't feel that strongly about it.
|
A few minor comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes here to support the three logical types that make sense with builtin Ruby types were relatively straightforward. But the actual use of these logical types found some issues with the proposed changes to the official avro gem: apache/avro#116. This required a new release of our fork.
Prime: @jturkel