Support symbols or strings as milestone keys #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfreeman
force-pushed
the
symbol-keys
branch
from
1d7c873
to
9c26a77
Compare
deverstalmage
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #9, this allows for the use of symbols as milestone keys. In terms of the actual runtime code, there were only a couple of small changes to the implementation:
Object.keysthat had to be replaced with something more generic, as that only returns string keys.toString()calls (thanks TypeScript, I would have forgotten about that!)One note: TS doesn't currently allow symbols in an index type (i.e.
{ [key: symbol]: any }isn't a thing), so there's a fewas anys sprinkled in to bypass that. If microsoft/TypeScript#26797 lands, we ought to be able to clean that up.@deverstalmage