Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0_numberStack - test and implementation #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

0_numberStack - test and implementation #2

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2dcf45
0_numberStack - test and implementation
Prince-Mask Dec 2, 2022
12abb0a
0_numberStack - fix top getter for empty NumberStack
Vacek-Petr-Neo Dec 2, 2022
7f3123d
0_numberStack - use beforeEach to make the test code shorter
Vacek-Petr-Neo Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 50 additions & 3 deletions ts-testing-training/src/0_numberStack/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,52 @@
describe('Stack', () => {
it('should do stuff', () => {
// do stuff!
import {NumberStack} from './index';

describe('NumberStack', () => {
/* worked initially
Copy link

@HankRoughknuckles HankRoughknuckles Dec 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note: If you want to initialize something for every test, you can use the beforeEach block like so:

  let testSubject: NumberStack;

  beforeEach(() => {
    testSubject = new NumberStack();
  })

  it('should return the last pushed value on pop() call', () => {
    testSubject.push(10);
    testSubject.push(5.5);

    expect(testSubject.pop()).toStrictEqual(5.5);
  });

// ...etc

it('should not return a value after push call', () => {
expect(testSubject.push(10)).toBe(undefined);
});
*/

it('should return the last pushed value on pop() call', () => {
const testSubject = new NumberStack();
testSubject.push(10);
testSubject.push(5.5);

expect(testSubject.pop()).toStrictEqual(5.5);
});

it('should return the correct value after subsequent pop() calls', () => {
const testSubject = new NumberStack();
testSubject.push(10);
testSubject.push(5.5);

testSubject.pop();
expect(testSubject.pop()).toStrictEqual(10);
});

it('should return the contents by accessing the contents property', () => {
const testSubject = new NumberStack();
testSubject.push(10);
testSubject.push(5.5);
const result = testSubject.contents;
expect(result.length).toStrictEqual(2);
});

it('should return the last inserted value on top', () => {
const testSubject = new NumberStack();
testSubject.push(10);
testSubject.push(5.5);

expect(testSubject.top).toStrictEqual(5.5);
});

/* Worked initially
it('should return the same value after subsequent top() calls', () => {
const testSubject = new NumberStack();
testSubject.push(10);
testSubject.push(5.5);

expect(testSubject.top).toStrictEqual(testSubject.top);
});
*/
});
12 changes: 6 additions & 6 deletions ts-testing-training/src/0_numberStack/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,24 +36,24 @@ export class NumberStack {

/** Puts a number on the top of the stack */
public push(input: number): void {
return;
this.list.push(input);
}

/** Remove the most recently pushed number from the stack and return it */
public pop(): number {
return 0;
public pop(): number | undefined {
return this.list.pop();
}

/**
* Returns the most recently pushed number in the stack. Does not modify the
* contents of the stack itself
*/
get top(): number {
return 0;
get top(): number | undefined {
return this.list[this.list.length-1];
}

/** Returns all the contents of the stack */
get contents(): number[] {
return [];
return this.list;
}
}
Loading