Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian docker repo has docker-engine package #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

taylorbyte
Copy link

Changed pkgs for Debian from docker-io to docker-engine. its the only package available in https://apt.dockerproject.org/repo/ for Debian.

Changed pkgs for Debian from `docker-io` to `docker-engine`. its the only package available in https://apt.dockerproject.org/repo/ for Debian.
@fpytloun
Copy link
Member

Hello,
correct community repository is deb [arch=amd64] https://download.docker.com/linux/debian/ stretch stable
and package name is docker-ce with latest version 17.12.0~ce-0~debian.

Default behavior here is to use docker.io which is Debian upstream package (https://tracker.debian.org/pkg/docker.io) unless overriden from pillar.

Copy link
Member

@fpytloun fpytloun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@taylorbyte
Copy link
Author

Sorry about that.
I don't mean to be rude I just want to help; i can't seem to find anywhere in the formula that sets the repo you referred to as default, this to me means the formula is incomplete or broken without directions on how to set the repo via a pillar, the only thing i can find about setting a repo is an example given here: https://github.com/salt-formulas/salt-formula-docker/blob/master/tests/pillar/repo_docker.sls which uses the repo i was referring to. It seems that some documentation is missing which should tell people which repo to use and how to set it using the "salt-formula-linux" formula which seems to be a prerequisite for this formula to work.

@fpytloun
Copy link
Member

fpytloun commented Feb 20, 2018

Formulas are not supposed to do what they are not supposed to. Eg. to setup repositories properly, there's salt-formula-linux.
But you are right that documentation should mention this + testing pillar should be fixed.
Will you update this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants