SALTO-7067: add accountElements utility to Workspace
#6963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamtamirr
changed the title
accountElements utility to Workspace (DRAFT)accountElements utility to Workspace
adamro
reviewed
Dec 18, 2024
| @@ -185,6 +187,12 @@ export type Workspace = { | |||
| uid: string | |||
|
|
|||
| elements: (includeHidden?: boolean, env?: string) => Promise<ElementsSource> | |||
| accountElements: (args: { | |||
There was a problem hiding this comment.
What's the reasoning behind this being a new function and not another param to elements?
There was a problem hiding this comment.
I think it made sense to have a dedicated implementation for a specific account's ElementsSource, where the account name is a required parameter.
Also, while I could add more optional parameters to elements, I think this would make the elements method harder to use, especially since it doesn't use an object parameter, (and changing it to an object parameter would cause a breaking change).
ori-moisis
requested changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add accountElements utility to Workspace.
coretoadapter-utils.Release Notes:
Workspace:
accountElementsthat returns ElementsSource of the provided account.User Notifications:
None