Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SALTO-7102: Supporting multiple "start" statuses in CLI deploy #7004

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yelly
Copy link
Contributor

@yelly yelly commented Dec 26, 2024

It is possible to receive multiple "start" statuses during deploy in the CLI which currently causes the action to never finish.
This PR solves this problem and prints the descriptions of the subsequent statuses.
Also fixed a couple of typos found while working on this.


Additional context for reviewer
Example output in deploy:

Starting the deployment plan
    Salesforce Metadata: Changing

    Salesforce Metadata: Still Changing (6s elapsed)

    Salesforce Metadata: Deployment with ID 0AfQy00000E9lpHKAR was created in Salesforce.

    Salesforce Metadata: 1/1 Metadata Components, 0/0 Tests. Elapsed Time: 3.264 seconds. View deployment status [in Salesforce](https://saltolabs8-dev-ed.develop.my.salesforce.com/lightning/setup/DeployStatus/page?address=%2Fchangemgmt%2FmonitorDeploymentsDetails.apexp%3FasyncId%3D0AfQy00000E9lpHKAR)

    Salesforce Metadata: Change completed after 10s


Deployment succeeded - 1 applied change(s).

Deployment summary:
✓ All elements were successfully deployed

You can see your deployment here:
https://saltolabs8-dev-ed.develop.my.salesforce.com/lightning/setup/DeployStatus/page?address=%2Fchangemgmt%2FmonitorDeploymentsDetails.apexp%3FasyncId%3D0AfQy00000E9lpHKAR

Release Notes:
None.


User Notifications:
None.

@yelly yelly requested a review from rotem531 December 26, 2024 15:18
@coveralls
Copy link

Coverage Status

coverage: 93.65% (-0.002%) from 93.652%
when pulling 56aec57 on yelly:SALTO-7102
into 90caa9b on salto-io:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants