Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(map): verify map.jinja dump using _mapdata state #56

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

sticky-note
Copy link
Member

@sticky-note sticky-note commented Apr 24, 2022

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

verify map.jinja dump using _mapdata state

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@sticky-note sticky-note requested review from baby-gnu and myii April 24, 2022 06:04
@sticky-note sticky-note requested a review from a team as a code owner April 24, 2022 06:04
@sticky-note sticky-note self-assigned this Apr 24, 2022
@sticky-note sticky-note force-pushed the test/map branch 3 times, most recently from 0d49595 to 54086f7 Compare April 24, 2022 06:36
@myii myii merged commit b2446fb into saltstack-formulas:master Apr 25, 2022
@myii
Copy link
Member

myii commented Apr 25, 2022

Merged, thanks for the PR, @sticky-note.

@myii
Copy link
Member

myii commented Apr 25, 2022

Reviewed using:

@saltstack-formulas-travis

🎉 This PR is included in version 1.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants