Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add some non "options" prefixed options #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekacnet
Copy link
Contributor

@ekacnet ekacnet commented Nov 30, 2022

Adding option like filename and next-server for the match section. There is a bit of refactoring done as well that could be extended to avoid repeating the options stuff everywhere...
It can be used in this kind of situation:

class "x32_uefi" {
    match if option clientarch = 00:06;
    filename "/tftpboot/bootia32.efi";
    next-server 1.2.3.4;
}

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

match sections of the DHCP config can have options name that don't start with options for instance filename or next-server

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

Adding option like filename and next-server for the match section.
There is a bit of refactoring done as well that could be extended to
avoid repeating the options stuff everywhere...
It can be used in this kind of situation:
```
class "x32_uefi" {
    match if option clientarch = 00:06;
    filename "/tftpboot/bootia32.efi";
    next-server 1.2.3.4;
}
```
@ekacnet ekacnet requested a review from sticky-note as a code owner November 30, 2022 16:53
@ekacnet
Copy link
Contributor Author

ekacnet commented Dec 8, 2022

Issues on gentoo seems unrelated to my changes, it seems the test environment is not working as expected anymore.

@ekacnet
Copy link
Contributor Author

ekacnet commented Dec 8, 2022

@myii you seems to be active on other pull requests and on this repository, can you have a look at this PR ?

@sticky-note
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants