Domain customization generates bogus entry #26
Labels
Comments
|
I had the same problem with salt-ssh and target centos 7. Your change fixed it. Thanks |
|
Thanks for confirming that, @cschneemann. Would you mind providing that PR, @lastmikoi? |
19 tasks
myii
pushed a commit
that referenced
this issue
Apr 28, 2020
* `<function caller at 0x7f4993c70aa0>` entries * Fixes #26
saltstack-formulas-travis
pushed a commit
that referenced
this issue
Apr 28, 2020
## [0.8.1](v0.8.0...v0.8.1) (2020-04-28) ### Bug Fixes * **init:** use `salt['pillar.get']` to avoid bogus entries ([ac98bb8](ac98bb8)), closes [#26](#26) ### Continuous Integration * **gemfile.lock:** add to repo with updated `Gemfile` [skip ci] ([cc147ec](cc147ec)) * **kitchen:** avoid using bootstrap for `master` instances [skip ci] ([01ca5cc](01ca5cc))
|
🎉 This issue has been resolved in version 0.8.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I'm a relatively new user of Salt and I've been working on a project that involves using this formula.
However, it would seem that the relatively recent
domainpart of the formula is not working properly in my environment:OS: CentOS 7
Saltstack:
2016.11.8with salt-ssh.Indeed, it generates entries such as this one:
As you can see, it doesn't seem to be able to actually grab the domain and instead prints a reference to a function, which changes every run.
I've been trying to tinker a bit with the code and replacing
salt.pillar.getwithsalt['pillar.get']in https://github.com/saltstack-formulas/hostsfile-formula/blob/master/hostsfile/init.sls#L23 seems to do the trick.If this workaround sounds reasonable I'll go ahead and open a PR with that modification but I am not familiar with best practices when it comes to making formulas so I'd rather get your input on that issue.
The text was updated successfully, but these errors were encountered: