feat(map): update to v5 map.jinja
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baby-gnu
force-pushed
the
feature/v5-map.jinja
branch
from
409d2ee to
6b97453
Compare
`map.jinja` is now generic, the post-processing is now done in `post-map.jinja`. The `java-formula` requires a dedicated `map.jinja` configuration to load values for the `kernel` grains. BREAKING CHANGE: `map.jinja` now export a generic `mapdata` variable BREAKING CHANGE: The parameters per grains are now under `java/parameters/`
We need to update the reference files to include the `map.jinja` sources configuration.
baby-gnu
force-pushed
the
feature/v5-map.jinja
branch
from
6b97453 to
80a3f8f
Compare
myii
approved these changes
Feb 25, 2021
|
Nice finale for this series of PRs, @baby-gnu! All good from my end but I'll just leave time for @noelmcloughlin, who is the main code owner here. |
|
It looks like I changed the order in which the values are loaded from the YAML files:
I can modify |
noelmcloughlin
approved these changes
Feb 25, 2021
Only if you are aware it causes a problem I guess. |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?Yes.
BREAKING CHANGE:
map.jinjanow export a genericmapdatavariableBREAKING CHANGE: The parameters per grains are now under
java/parameters/Related issues and/or pull requests
Describe the changes you're proposing
map.jinjais now generic, the post-processing is now done injava/post-map.jinja.The
java-formularequires a dedicatedmap.jinjaconfiguration to load values for thekernelgrains.Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context