Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kitchen): we should run tests with the upstream Lynis repository #7

Merged
merged 2 commits into from
Sep 22, 2020
Merged

fix(kitchen): we should run tests with the upstream Lynis repository #7

merged 2 commits into from
Sep 22, 2020

Conversation

n-rodriguez
Copy link
Member

@n-rodriguez n-rodriguez commented Sep 22, 2020 •
edited
Loading

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@pull-assistant
Copy link

pull-assistant bot commented Sep 22, 2020 •
edited
Loading

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     fix(kitchen): we should run tests with the upstream Lynis repository

     feat(states): add support for Redhat and Suse

Powered by Pull Assistant. Last update 43104a9 ... ffb5aaa. Read the comment docs.

@n-rodriguez n-rodriguez mentioned this pull request Sep 22, 2020
Closed
@n-rodriguez n-rodriguez requested a review from a team as a code owner September 22, 2020 11:55
@n-rodriguez
Copy link
Member Author

OpenSuse is broken because it can't download the signing key :

2020-09-22 14:17:42 <1> 75efa8649c15(434) [zypp++] MediaCurl.cc(doGetFileCopyFile):1139 URL: https://packages.cisofy.com/community/lynis/rpm/repodata/repomd.xml.asc
2020-09-22 14:17:42 <1> 75efa8649c15(434) [zypp++] MediaCurl.cc(doGetFileCopyFile):1139 URL: https://packages.cisofy.com/community/lynis/rpm/repodata/repomd.xml.key
2020-09-22 14:17:42 <5> 75efa8649c15(434) [zypp] Exception.cc(log):166 MediaCurl.cc(evaluateCurlCode):762 THROW:    File '/repodata/repomd.xml.key' not found on medium 'https://packages.cisofy.com/community/lynis/rpm/'
2020-09-22 14:17:42 <5> 75efa8649c15(434) [zypp] Exception.cc(log):166 MediaCurl.cc(doGetFileCopyFile):1220 RETHROW:  File '/repodata/repomd.xml.key' not found on medium 'https://packages.cisofy.com/community/lynis/rpm/'
2020-09-22 14:17:42 <5> 75efa8649c15(434) [zypp] Exception.cc(log):166 MediaMultiCurl.cc(doGetFileCopy):1364 RETHROW:  File '/repodata/repomd.xml.key' not found on medium 'https://packages.cisofy.com/community/lynis/rpm/'
2020-09-22 14:17:42 <5> 75efa8649c15(434) [zypp] Exception.cc(log):166 MediaCurl.cc(getFileCopy):649 RETHROW:  File '/repodata/repomd.xml.key' not found on medium 'https://packages.cisofy.com/community/lynis/rpm/'
2020-09-22 14:17:42 <5> 75efa8649c15(434) [zypp] Exception.cc(log):166 MediaSetAccess.cc(provide):266 CAUGHT:   File '/repodata/repomd.xml.key' not found on medium 'https://packages.cisofy.com/community/lynis/rpm/'

2020-09-22 15:20:53 <1> 75efa8649c15(3199) [zypp:fetcher] Fetcher.cc(provideToDest):518 Not found in cache, retrieving...
2020-09-22 15:20:53 <1> 75efa8649c15(3199) [zypp++] MediaSetAccess.cc(provide):253 Going to try to provide optional file /repodata/repomd.xml.key from media number 1
2020-09-22 15:20:53 <1> 75efa8649c15(3199) [zypp++] MediaManager.cc(checkDesired):98 checkDesired(2): desired (cached)
2020-09-22 15:20:53 <1> 75efa8649c15(3199) [zypp++] MediaManager.cc(checkDesired):98 checkDesired(2): desired (cached)
2020-09-22 15:20:53 <1> 75efa8649c15(3199) [zypp++] MediaMultiCurl.cc(doGetFileCopy):1335 dest: /var/tmp/AP_0xavfFJW/repodata/repomd.xml.key
2020-09-22 15:20:53 <1> 75efa8649c15(3199) [zypp++] MediaMultiCurl.cc(doGetFileCopy):1336 temp: /var/tmp/AP_0xavfFJW/repodata/repomd.xml.key.new.zypp.KjZT0r
2020-09-22 15:20:53 <1> 75efa8649c15(3199) [zypp++] MediaCurl.cc(doGetFileCopyFile):1129 /repodata/repomd.xml.key
2020-09-22 15:20:53 <1> 75efa8649c15(3199) [zypp++] MediaCurl.cc(doGetFileCopyFile):1139 URL: https://packages.cisofy.com/community/lynis/rpm/repodata/repomd.xml.key
2020-09-22 15:20:53 <3> 75efa8649c15(3199) [zypp] MediaCurl.cc(doGetFileCopyFile):1204 curl error: 22: The requested URL returned error: 404 , temp file size 0 bytes.
2020-09-22 15:20:53 <5> 75efa8649c15(3199) [zypp] Exception.cc(log):166 MediaCurl.cc(evaluateCurlCode):762 THROW:    File '/repodata/repomd.xml.key' not found on medium 'https://packages.cisofy.com/community/lynis/rpm/'
2020-09-22 15:20:53 <5> 75efa8649c15(3199) [zypp] Exception.cc(log):166 MediaCurl.cc(doGetFileCopyFile):1220 RETHROW:  File '/repodata/repomd.xml.key' not found on medium 'https://packages.cisofy.com/community/lynis/rpm/'
2020-09-22 15:20:53 <5> 75efa8649c15(3199) [zypp] Exception.cc(log):166 MediaMultiCurl.cc(doGetFileCopy):1364 RETHROW:  File '/repodata/repomd.xml.key' not found on medium 'https://packages.cisofy.com/community/lynis/rpm/'
2020-09-22 15:20:53 <1> 75efa8649c15(3199) [zypp] PathInfo.cc(unlink):659 unlink /var/tmp/AP_0xavfFJW/repodata/repomd.xml.key.new.zypp.KjZT0r
2020-09-22 15:20:53 <5> 75efa8649c15(3199) [zypp] Exception.cc(log):166 MediaCurl.cc(getFileCopy):649 RETHROW:  File '/repodata/repomd.xml.key' not found on medium 'https://packages.cisofy.com/community/lynis/rpm/'
2020-09-22 15:20:53 <5> 75efa8649c15(3199) [zypp] Exception.cc(log):166 MediaSetAccess.cc(provide):266 CAUGHT:   File '/repodata/repomd.xml.key' not found on medium 'https://packages.cisofy.com/community/lynis/rpm/'
2020-09-22 15:20:53 <5> 75efa8649c15(3199) [zypp] Exception.cc(log):166 Fetcher.cc(provideToDest):556 RETHROW:  Signature verification failed for repomd.xml
2020-09-22 15:20:53 <5> 75efa8649c15(3199) [zypp] Exception.cc(log):166 History:
2020-09-22 15:20:53 <5> 75efa8649c15(3199) [zypp] Exception.cc(log):166  - Can't provide /repodata/repomd.xml

@n-rodriguez
Copy link
Member Author

OpenSuse is broken because it can't download the signing key :

I've sent a mail to support@cisofy.com to ask them to create https://packages.cisofy.com/community/lynis/rpm/repodata/repomd.xml.key

@myii myii merged commit 6e1aa8f into saltstack-formulas:master Sep 22, 2020
@myii
Copy link
Member

myii commented Sep 22, 2020

Lovely work, thanks @n-rodriguez.

@saltstack-formulas-travis
Copy link

🎉 This PR is included in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myii myii myii approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n-rodriguez @myii @saltstack-formulas-travis