Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(inspec): switch tests to use Inspec #220

Merged
merged 3 commits into from
Apr 12, 2019

Conversation

daks
Copy link
Member

@daks daks commented Apr 12, 2019

After discussion on slack, a PR to switch to tests with Inspec. Those are basics, testing pkg/file/service.
General CI config copied from https://github.com/saltstack-formulas/template-formula/ master, so commitlint included.

@daks daks requested review from myii and aboe76 April 12, 2019 19:01
@javierbertoli
Copy link
Member

Awesome. I'd probably remove the test/salt/default/pillar/nginx.sls and Gemfile.lock files?

Copy link
Member

@aboe76 aboe76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daks, wow nice work, and I concur with @javierbertoli

@daks daks force-pushed the kitchen-tests branch 2 times, most recently from 2ecdaa3 to 080bd25 Compare April 12, 2019 20:15
@daks
Copy link
Member Author

daks commented Apr 12, 2019

Files removed or emptied.

@daks daks force-pushed the kitchen-tests branch 2 times, most recently from c12cbc1 to e6ab92e Compare April 12, 2019 20:28
@daks
Copy link
Member Author

daks commented Apr 12, 2019

CentOS 7 test disabled for now, but it's still better than no tests at all 🍾

@myii myii merged commit 35a81c8 into saltstack-formulas:master Apr 12, 2019
@myii
Copy link
Member

myii commented Apr 13, 2019

@daks Merged -- thanks for fixing the tests in this formula. A very impressive job, as we've already discussed on Slack. Just to bring across the important notes here:

  • Left semantic-release (and commitlint) for a future PR.
  • Used the newest testing matrix from salt-formula instead of the template-formula, as based on this merged PR by @javierbertoli: Update the testing matrix (5 distros, 2 python versions, 3 salt versions) salt-formula#406.
  • Disabled the Salt version-specific test suites for the time being (using default throughout) -- need to create an issue to remind us that this work is still needed.
  • Commented out centos-7 because it is currently failing (on the salt-formula as well, since around 4 days ago) -- Daniel mentioned probably due to work being done on releasing python3.6 versions of salt for centos 7 -- need to create an issue to retest this in the next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants