Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(inspec): more tests on nginx config #222

Merged
merged 2 commits into from
Apr 17, 2019
Merged

test(inspec): more tests on nginx config #222

merged 2 commits into from
Apr 17, 2019

Conversation

daks
Copy link
Member

@daks daks commented Apr 12, 2019

Some more tests on config files generated: snippets and sites

@myii
Copy link
Member

myii commented Apr 13, 2019

@daks The new testing matrix is doing it's job! So the tests are passing for Debian and Ubuntu but not the other platforms.

@daks
Copy link
Member Author

daks commented Apr 13, 2019

Yes, I wrote those naively, based on Debian knowledge. I now need to adapt them to other platforms, looking at the code.

@daks daks mentioned this pull request Apr 13, 2019
Closed
@daks daks force-pushed the more-kitchen branch 2 times, most recently from a9583c1 to 5482f37 Compare April 13, 2019 12:17
@daks
Copy link
Member Author

daks commented Apr 13, 2019

After disabling OpenSuse42 tests, all pass.

@myii
Copy link
Member

myii commented Apr 13, 2019 •
edited
Loading

@daks Fantastic work. If opensuse can't be fixed, this is ready to be merged, right? In the meantime, @aboe76 do you have any suggestions about how we can get it working? The last failing log is here. Linked issue: #224.

@daks
Copy link
Member Author

daks commented Apr 13, 2019

@myii for me, it's ok to merge without opensuse

@myii myii mentioned this pull request Apr 13, 2019
Open
myii
myii requested changes Apr 13, 2019
View reviewed changes
Copy link
Member

@myii myii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After our discussions on Slack, we've determined how to get opensuse working. Those changes need to be transferred to this PR before merging.

@daks
Copy link
Member Author

daks commented Apr 16, 2019

@myii can you refresh my memory about this PR and what is still missing?

@myii
Copy link
Member

myii commented Apr 16, 2019

@daks Just need to append this commit: myii@3fa262b.

@myii myii merged commit c24d2b6 into saltstack-formulas:master Apr 17, 2019
@myii
Copy link
Member

myii commented Apr 17, 2019

Brilliant @daks, thanks for this beneficial PR! Merged.

@daks daks deleted the more-kitchen branch April 18, 2019 08:59
@daks
Copy link
Member Author

daks commented Apr 18, 2019

Thanks for merging and for solving opensuse :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myii myii myii requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daks @myii