Fix pidfile to match PIDFile in systemd service #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
commit 393d69e changed one path, but I think it applies only for Ubuntu, not for Debian. And I think fpm/config.sls needs to be changed too when multiple versions are installed. |
Systemd services from packages.sury.org/php repository have PIDFile in /run/php directory, and latest package 7.4.2-5 has ExecStartPost which fails with timeout if PIDFile is not found.
For Debian with latest packages from packages.sury.org/php repository, when only one version is installed
|
Sorry for the delay, @scambra. Could you have a look at this, @sticky-note? |
sticky-note
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had php fpm installed from packages.sury.org/php repository on Debian 10. When I upgraded to latest version (7.4.2-5 and 5.6.40-20) fpm failed to restart.
PIDFile in systemd service for sury packages have always been:
PIDFile=/run/php/phpVERSION-fpm.pid
Starting service worked for previous versions, but latest versions have these lines in systemd services, which make start to fail if pid file is not found:
ExecStartPost=-update-alternatives --quiet --install /run/php/php-fpm.sock php-fpm.sock /run/php/phpVERSION-fpm.sock VERSION
ExecStopPost=-update-alternatives --quiet --remove php-fpm.sock /run/php/phpVERSION-fpm.sock