-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(map): standardise map.jinja
verification
#69
test(map): standardise map.jinja
verification
#69
Conversation
Best reviewed: commit by commit
Optimal code review plan
|
@daks Realised I could use Then it was a matter of figuring out how to grab the |
Good job @myii :) At a side note, I recently upgraded to Inspec4 and we use the |
570730a
to
7b0e1ec
Compare
describe yaml
insteadmap.jinja
verification
Repurposed this PR with all of the standardisations worked out across the various formulas. |
7b0e1ec
to
b7aa04d
Compare
Self-merging since tests only. |
🎉 This PR is included in version 0.23.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
UPDATE:
map.jinja
dump using_mapdata
state #68map.jinja
verification myii/ssf-formula#281#65 (comment)saltstack-formulas/openssh-formula#193Describe the changes you're proposing
Discussion in Slack: https://freenode.logbot.info/saltstack-formulas/20200826#c4886021-c4887283.
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context