Formula based off template can't be moved from the root salt directory

[redundancydisorder]

The template assumes the formula will always live in salt:// as noted here:

{% from "template/map.jinja" import template with context %}

It would be better to use:

{% from tpldir ~ "/map.jinja" import template with context %}

[myii]

@redundancydisorder Welcome to GitHub! And thanks for this request -- did we just communicate on Slack?

The idea is an excellent one. However, there is a stumbling block that we're going to have to consider:

• Find a solution for tpldir not working in template files, see Can't use tpldir or slspath in template file saltstack/salt#41195.

There may be a solution soon:

• Evaluate if relative paths can be used, see Support Jinja imports with relative paths. Issue #13889 saltstack/salt#47490.

[redundancydisorder]

Yes I was on the salt slack. I have been testing internally modifying existing formulas (users, bind, dhcpd, apache) to function when not in the root salt directory. I was just hoping that addressing this in the template as well as changes to popular formulas would change the overall formula design to be more portable.

[myii]

@redundancydisorder Unfortunately, we can't apply the changes across formulas until we get a solution from upstream, as linked in my comment above. Looking at the commit tags:

• develop (#47490) v2019.2.0rc2 v2019.2.0rc1 v2019.2 v2018.11

Looks like we're a bit stuck, since our formulas have to work with Salt versions that are still officially supported. This is going to be a tough one.

[myii]

@redundancydisorder In terms of tpldir working in templates, there is the workaround of sending it through as a context variable.

[myii]

A probable solution introduced with 068a94d (#28):

template-formula/template/macros.jinja

Line 46 in 068a94d

{%- set topdir = tpldir.split('/')[0] %}

[myii]

@redundancydisorder This should work for you now.

[saltstack-formulas-travis]

🎉 This issue has been resolved in version 0.7.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀