ci(gitlab-ci): use Node 16.x for pre-commit in test conversion job
#249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test_conversion` job failed during the weekly testing: * https://gitlab.com/myii/template-formula/-/jobs/2371193438 The `stderr` being: ``` /root/.cache/pre-commit/repomigj3p4n/node_env-default/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /root/.cache/pre-commit/repomigj3p4n/node_env-default/bin/node) ``` The following references led to this resolution: * pre-commit/pre-commit#2351 * https://stackoverflow.com/questions/71939099/bitbucket-pipeline-error-installing-pre-commit-ts-lint As mentioned there: > a few days ago node 18.x was released and the prebuilt binaries > require a relatively-recent version of glibc Which obviously isn't available on our current Bionic-based `dind` image, i.e. 'myii/ssf-dind-ruby-bionic:2.7.5-1bbox1'. While debugging this situation locally, noticed that the use of a relative `tmp/...` subdirectory was within the `template-formula` directory itself -- so switched this to using `/tmp/...` instead.
dafyddj
approved these changes
Apr 25, 2022
|
Thanks for the prompt review, @dafyddj. |
|
🎉 This PR is included in version 5.0.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
myii
added a commit
to myii/ssf-formula
that referenced
this pull request
May 10, 2022
myii
added a commit
that referenced
this pull request
May 10, 2022
saltstack-formulas-github
pushed a commit
that referenced
this pull request
Nov 13, 2023
## [5.0.10](v5.0.9...v5.0.10) (2023-11-13) ### Bug Fixes * broken install-hooks due to saltlint v0.8.0 ([7da11c9](7da11c9)) ### Continuous Integration * update the container images and refactor steps ([b84343e](b84343e)) * **commitlint:** update action versions ([c69928d](c69928d)) * update `pre-commit` configuration inc. for pre-commit.ci [skip ci] ([32518b9](32518b9)) * **gitlab-ci:** fix test conversion job (reset back to [#249](#249)) [skip ci] ([6ea1cc2](6ea1cc2)) ### Styles * **default.sls:** fix minor typo ([3d1581e](3d1581e)) * **inspec:** fix whitespace ([1df9861](1df9861)) ### Tests * **_mapdata:** add verification file for `ubuntu-22` [skip ci] ([9349c83](9349c83)) * **pre-commit:** switch to using `pre-commit`'s built-in file filtering ([46130c4](46130c4)) * **pre-commit:** update `pre-commit` hooks ([2bd3ef9](2bd3ef9)) * **rstcheck:** ignore Markdown-style links as false positives ([b2c28aa](b2c28aa)) * **system.rb:** add support for `mac_os_x` [skip ci] ([d46507b](d46507b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
Describe the changes you're proposing
The
test_conversionjob failed during the weekly testing:The
stderrbeing:The following references led to this resolution:
As mentioned there:
Which obviously isn't available on our current Bionic-based
dindimage,i.e. 'myii/ssf-dind-ruby-bionic:2.7.5-1bbox1'.
While debugging this situation locally, noticed that the use of a
relative
tmp/...subdirectory was within thetemplate-formuladirectory itself -- so switched this to using
/tmp/...instead.Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context