feat: allow install_from_repo #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze42
force-pushed
the
from_repo
branch
3 times, most recently
from
75eafc1
to
07a25b9
Compare
|
Any hint on how to write specific tests for those? |
|
Hi, thanks for your contribution. Let me take a couple of days to take a look at this. |
|
@dafyddj had you any time in the last months? |
|
Hi, sorry for the long delay. Can you rebase this PR and push to re-run the tests? |
dafyddj
requested changes
Jan 26, 2023
pillar.example
Outdated
Comment on lines
147
to
149
| install_from_repo: False # Set to True to install package rather than extract archive | ||
| repo: ... # Might specify a specific repo, if not present in map | ||
| package: vault # If package would have any other name |
There was a problem hiding this comment.
Please observe the yaml formatting problems covered by pre-commit.
The pillar values are self-explanatory, so do not require commenting but please supply an actual example value for repo.
vault/osfamilymap.yaml
Outdated
Comment on lines
7
to
8
| repo_key: "https://apt.releases.hashicorp.com/gpg" | ||
| repo_configfile: '/etc/vault.d/vault.hcl' |
vault/osfamilymap.yaml
Outdated
| @@ -3,6 +3,9 @@ | |||
| --- | |||
| Debian: | |||
| setcap_pkg: libcap2-bin | |||
| repo: "deb [arch={{ grains['osarch'] }}] https://apt.releases.hashicorp.com {{ grains['oscodename'] }} main" | |||
There was a problem hiding this comment.
Please split long lines.
Suggested change
| repo: "deb [arch={{ grains['osarch'] }}] https://apt.releases.hashicorp.com {{ grains['oscodename'] }} main" | |
| repo: 'deb [arch={{ grains['osarch'] }}] https://apt.releases.hashicorp.com | |
| {{ grains['oscodename'] }} main' |
There was a problem hiding this comment.
fixed. Along other stuffs, to get CI ok.
ze42
force-pushed
the
from_repo
branch
5 times, most recently
from
734644a
to
8653424
Compare
Allow install via package from a repository
|
Is there a status update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vault debian repo added as an option
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
Related to #53
Describe the changes you're proposing
Support install from (hashicorp) repo - with proper defaults for Debian
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context