Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with Pylint 3 #48

Closed
max-arnold opened this issue Oct 6, 2023 · 1 comment
Closed

Incompatible with Pylint 3 #48

max-arnold opened this issue Oct 6, 2023 · 1 comment
Assignees
@s0undt3ch

Comments

@max-arnold
Copy link 

ImportError: cannot import name 'IRawChecker' from 'pylint.interfaces' (/Users/user/.cache/pre-commit/repoz5pliu_c/py_env-python3.9/lib/python3.9/site-packages/pylint/interfaces.py)
MaxBear added a commit to MaxBear/salt-pylint that referenced this issue Jan 30, 2024
@MaxBear
modify saltpylint for pylint 3.0.3
904a3a9 
Current saltpylint works with pylint==2.13.9. It does not work with
newer versions of pylint such as 2.17 ... 3.0.3. Pylint 3.0.3 includes
many code changes, such as remove exposed checker interfaces, remove
some @utils fucitons, remove checker member functions (config)  .. The
submitted pr removes those disappeared functions. Review is required to
make sure it does not remove necessary checks as a result.

This commit will fix issues
- saltstack#48
- saltstack#47
@MaxBear MaxBear mentioned this issue Jan 30, 2024
Merged
s0undt3ch pushed a commit that referenced this issue Feb 1, 2024
@MaxBear @s0undt3ch
modify saltpylint for pylint 3.0.3
0e1b485 
Current saltpylint works with pylint==2.13.9. It does not work with
newer versions of pylint such as 2.17 ... 3.0.3. Pylint 3.0.3 includes
many code changes, such as remove exposed checker interfaces, remove
some @utils fucitons, remove checker member functions (config)  .. The
submitted pr removes those disappeared functions. Review is required to
make sure it does not remove necessary checks as a result.

This commit will fix issues
- #48
- #47
@s0undt3ch
Copy link
Contributor

This is now fixed

@s0undt3ch s0undt3ch self-assigned this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s0undt3ch s0undt3ch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@s0undt3ch @max-arnold