Skip to content

Commit

Permalink
Fixed linter errors
Browse files Browse the repository at this point in the history
  • Loading branch information
Akm0d committed Dec 2, 2019
1 parent 04a2619 commit e73c4c9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
3 changes: 1 addition & 2 deletions salt/modules/pip.py
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ def install(pkgs=None, # pylint: disable=R0912,R0913,R0914
extra_args
pip keyword and positional arguments not yet implemented in salt
.. code-block:: yaml
salt '*' pip.install pandas extra_args="[{'--latest-pip-kwarg':'param'}, '--latest-pip-arg']"
Expand All @@ -624,7 +624,6 @@ def install(pkgs=None, # pylint: disable=R0912,R0913,R0914
pip install pandas --latest-pip-kwarg param --latest-pip-arg
disable_version_check
Pip may periodically check PyPI to determine whether a new version of
pip is available to download. Passing True for this option disables
Expand Down
2 changes: 1 addition & 1 deletion salt/states/pip_state.py
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ def installed(name,
extra_args
pip keyword and positional arguments not yet implemented in salt
.. code-block:: yaml
pandas:
Expand Down
7 changes: 2 additions & 5 deletions tests/unit/modules/test_pip.py
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,7 @@ def test_install_multiple_requirements_arguments_in_resulting_command(self):
use_vt=False,
python_shell=False,
)

def test_install_extra_args_arguments_in_resulting_command(self):
pkg = 'pep8'
mock = MagicMock(return_value={'retcode': 0, 'stdout': ''})
Expand Down Expand Up @@ -838,8 +838,6 @@ def test_install_extra_args_arguments_recursion_error(self):
{"--latest-pip-kwarg": [{"--too-deep": dict()}]},
]))



def test_uninstall_multiple_requirements_arguments_in_resulting_command(self):
with patch('salt.modules.pip._get_cached_requirements') as get_cached_requirements:
cached_reqs = [
Expand Down Expand Up @@ -1317,8 +1315,7 @@ def test_is_installed_false(self):

def test_install_pre_argument_in_resulting_command(self):
pkg = 'pep8'
# Lower than 1.4 versions don't end-up with `--pre` in the resulting
# output
# Lower than 1.4 versions don't end up with `--pre` in the resulting output
mock = MagicMock(side_effect=[
{'retcode': 0, 'stdout': 'pip 1.2.0 /path/to/site-packages/pip'},
{'retcode': 0, 'stdout': ''}
Expand Down

0 comments on commit e73c4c9

Please sign in to comment.