Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update doc pr's to be built using python3 and sphinx 2.0.1 #53137

Closed
bryceml opened this issue May 20, 2019 · 2 comments
Closed

update doc pr's to be built using python3 and sphinx 2.0.1 #53137

bryceml opened this issue May 20, 2019 · 2 comments
Assignees
@s0undt3ch @bryceml
Labels
Documentation Relates to Salt documentation
Milestone
Approved

Comments

@bryceml
Copy link
Contributor

bryceml commented May 20, 2019

Description of Issue/Question

Doc PR's are tested using python2, I'm not sure of the version of sphinx, however, the actual docs that go on docs.saltstack.com are built using python3 and sphinx 2.0.1.

We need to move the pr builds to run on python3

The means update

  • .ci/docs
  • requirements/static/docs.in
  • update things in sre-jenkins

verify it works.
@bryceml bryceml added Documentation Relates to Salt documentation TEAM Core labels May 20, 2019
@twangboy twangboy added this to the Approved milestone May 20, 2019
This was referenced May 28, 2019
Merged
Merged
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 28, 2019
@s0undt3ch
Switch docs building under Py3
a075b7b 
Refs saltstack#53137
Akm0d pushed a commit that referenced this issue May 28, 2019
@s0undt3ch @Akm0d
Switch docs building under Py3 (#53272)
e138030 
Refs #53137
@s0undt3ch s0undt3ch mentioned this issue May 29, 2019
Merged
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 29, 2019
@s0undt3ch
Switch docs building under Py3
07f4327 
Refs saltstack#53137
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Jul 4, 2019
@s0undt3ch
Switch docs building under Py3
e989176 
Refs saltstack#53137
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Jul 4, 2019
@s0undt3ch
Switch docs building under Py3
ee504d6 
Refs saltstack#53137
@s0undt3ch
Copy link
Collaborator

2018.3, 2019.2.1, neon and develop have migrated to building docs on Py3.
2019.2 will get that when the merge-forward is merged.
2017.7.9 and 2017.7 need extra work to switch.

johnclyde pushed a commit to johnclyde/salt that referenced this issue Aug 5, 2019
@s0undt3ch @johnclyde
Switch docs building under Py3
08505ed 
Refs saltstack#53137
@bryceml
Copy link
Contributor Author

bryceml commented Nov 19, 2019

This is done.

@bryceml bryceml closed this as completed Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s0undt3ch s0undt3ch

@bryceml bryceml

Labels
Documentation Relates to Salt documentation
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
3 participants
@s0undt3ch @twangboy @bryceml