virt.pool_delete fast parameter is inversed and useless #54474
Assignees
Labels
Bug
broken, incorrect, or confusing behavior
fixed-pls-verify
fix is linked, bug author to confirm fix
P4
Priority 4
stale
Milestone
Comments
xeacott
added
fixed-pls-verify
cbosdo
added a commit
to cbosdo/salt
that referenced
this issue
Nov 26, 2019
There are two reasons to remove this parameter without deprecating it: * the meaning has been mistakenly inversed * fast=True will raise an exception for every libvirt storage backend since that flag has never been implemented in any of those. Fixes issue saltstack#54474
cbosdo
added a commit
to cbosdo/salt
that referenced
this issue
Dec 6, 2019
There are two reasons to remove this parameter without deprecating it: * the meaning has been mistakenly inversed * fast=True will raise an exception for every libvirt storage backend since that flag has never been implemented in any of those. Fixes issue saltstack#54474
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue. |
|
Fixed now |
admd
pushed a commit
to admd/salt-1
that referenced
this issue
Jan 27, 2020
There are two reasons to remove this parameter without deprecating it: * the meaning has been mistakenly inversed * fast=True will raise an exception for every libvirt storage backend since that flag has never been implemented in any of those. Fixes issue saltstack#54474
agraul
pushed a commit
to agraul/salt
that referenced
this issue
Apr 22, 2020
There are two reasons to remove this parameter without deprecating it: * the meaning has been mistakenly inversed * fast=True will raise an exception for every libvirt storage backend since that flag has never been implemented in any of those. Fixes issue saltstack#54474
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of Issue
Introduced in 2019.2.0, the
virt.pool_delete()function has afastparameter. There are two issues with this parameter:it is inversed with its meaning.
fast=Trueactually adds thelibvirt.VIR_STORAGE_POOL_DELETE_ZEROEDflag, that should zero the pool and make the delete operation much slower.After investigations, none of the libvirt storage backends actually implements this flag, which means that in all cases the default
virt.pool_delete()call will raise a libvirt exception like the following one:The proposed solution would be to completely remove the
fastparameter. In all cases changing this part of the API shouldn't hurt, since defaults don't work at all.The text was updated successfully, but these errors were encountered: