[BUG] lxd module imcompatible with pylxd >= 2.2.11

[goapunk]

Description
The lxd module uses a hack which overwrites the FileManager class of pylxd. In pylxd >= 2.2.11 this class changed and creating container in salt will fail.

Setup
saltstack + pylxd==2.2.11

Steps to Reproduce the behavior
Create a container through the lxd module

Expected behavior
Creating container should work with pylxd >= 2.2.11

Additional context
The following patch should make it work on 2.2.11 but I did not test it thoroughly. In general getting rid of the hack would be much better.

diff --git a/salt/modules/lxd.py b/salt/modules/lxd.py                          
index 7c8f9fb..d3528ae 100644                                                   
--- a/salt/modules/lxd.py                                                       
+++ b/salt/modules/lxd.py                                                       
@@ -3656,9 +3656,8 @@ if HAS_PYLXD:                                             
                 headers["X-LXD-uid"] = six.text_type(uid)                      
             if gid is not None:                                                
                 headers["X-LXD-gid"] = six.text_type(gid)                      
-            response = self._client.api.containers[self._container.name].files.post(
-                params={"path": filepath}, data=data, headers=headers          
-            )                                                                  
+            response = self._instance.client.api.containers[self._instance.name]
+                .files.post(params={'path': filepath}, data=data, headers=headers)
             return response.status_code == 200                                 
                                                                               
     Container.FilesManager = FilesManager

Related to / Duplicate of #57822

[sagetherage]

we will review a PR if you are willing to submit one! :)

[Ch3LL]

@goapunk would you be willing to submit a PR? We would also need to account for older versions of the library. If there is an easy way to check for the version we could take that approach, or possibly catch the exception and use the new attribute.

[goapunk]

@Ch3LL I currently can't really say when I will have the time to work on it, so I have to pass for now.

[Ch3LL]

No worries, thanks for getting back to me :)

[goapunk]

@Ch3LL I've opened #63911 to address this