fix: lxd remove outdated monkey patch #63911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goapunk
changed the title
Ch3LL
suggested changes
Mar 20, 2023
goapunk
commented
Mar 21, 2023
goapunk
force-pushed
the
jd-2023-03-lxd-remove-outdated-monkey-patch
branch
from
6a8ecef
to
4529501
Compare
|
I added changelogs for both fixes |
Ch3LL
suggested changes
Mar 22, 2023
goapunk
force-pushed
the
jd-2023-03-lxd-remove-outdated-monkey-patch
branch
2 times, most recently
from
ccbb04b
to
69964e0
Compare
goapunk
force-pushed
the
jd-2023-03-lxd-remove-outdated-monkey-patch
branch
2 times, most recently
from
ae1d4a6
to
8110697
Compare
Ch3LL
previously approved these changes
Mar 23, 2023
goapunk
changed the title
goapunk
force-pushed
the
jd-2023-03-lxd-remove-outdated-monkey-patch
branch
from
8110697
to
5cd553c
Compare
goapunk
changed the title
3 tasks
Ch3LL
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
* Fix bug in lxd module which made it impossible to add devices (taken from device_type is not valid for lxd and it generate change all time #59646), credits go to @aarnaudWhat issues does this PR fix or reference?
Fixes: #59514
Previous Behavior
* Creation of devices (which are not of type disk) would failNew Behavior
* devices of all types can be addedMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.