Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Masterless master tops #65479

Closed
lkubb opened this issue Oct 28, 2023 · 2 comments · Fixed by #65481
Closed

[FEATURE REQUEST] Masterless master tops #65479

lkubb opened this issue Oct 28, 2023 · 2 comments · Fixed by #65481
Labels
Feature new functionality including changes to functionality and code refactors, etc. needs-triage

Comments

@lkubb
Copy link
Contributor

lkubb commented Oct 28, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
Masterless minions currently do not support master tops, which is a feature discrepancy vs regular Salt.

Describe the solution you'd like
When opts["file_client"] == "local", evaluate master top modules locally.

Describe alternatives you've considered
None.

Additional context
#27930
@lkubb lkubb added Feature new functionality including changes to functionality and code refactors, etc. needs-triage labels Oct 28, 2023
This was referenced Oct 28, 2023
Closed
Merged
@OrangeDog
Copy link
Contributor

What would "master tops" mean when there is no master?

@lkubb
Copy link
Contributor Author

lkubb commented Oct 30, 2023 •
edited
Loading

What would "master tops" mean when there is no master?

Just some external data source providing the targeted states for a highstate, as usual. Pillar modules work on masterless minions as well, this is roughly the state equivalent (without providing the actual states admittedly).

Edit: Not sure why they are called master tops anyways, they are top modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature new functionality including changes to functionality and code refactors, etc. needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[master] Support master tops on masterless minions lkubb/salt
2 participants
@OrangeDog @lkubb