You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
When multiple master top modules are defined and return targeted states for the same environment, salt-ssh does not merge the returns, but only keeps the last one. This is a discrepancy vs. regular Salt.
Setup
Enable two master top modules which return states for the same saltenv, e.g. base in the master config.
Steps to Reproduce the behavior
Check the output of salt-ssh foobar state.show_top.
Expected behavior
Lists should be merged, as usual.
lkubb
changed the title
[BUG] salt-ssh does not merge environments from master tops
[BUG] salt-ssh does not merge master top returns per saltenv
Oct 28, 2023
Description
When multiple master top modules are defined and return targeted states for the same environment,
salt-ssh
does not merge the returns, but only keeps the last one. This is a discrepancy vs. regular Salt.Setup
Enable two master top modules which return states for the same saltenv, e.g.
base
in the master config.Steps to Reproduce the behavior
Check the output of
salt-ssh foobar state.show_top
.Expected behavior
Lists should be merged, as usual.
Screenshots
salt/salt/client/ssh/state.py
Lines 107 to 111 in 93b6405
salt/salt/daemons/masterapi.py
Lines 533 to 539 in 93b6405
Versions Report
current master
Additional context
I just stumbled over this while writing a PR for #65479. Thought it was noteworthy enough.
Tangentially related: #59802
The text was updated successfully, but these errors were encountered: