Add full_return to release notes #41356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whiteinge, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terminalmage, @rallytime and @mirceaulinic to be potential reviewers. |
rallytime
reviewed
May 20, 2017
doc/topics/releases/nitrogen.rst
Outdated
|
|
||
| An ``full_return`` argument has been added to the ``cmd`` and ``cmd_sync`` | ||
| methods in ``LocalClient`` and ``RunnerClient`` which causes the return data | ||
| structure to include job meta data such as ``ret_code`` and ``success``. |
There was a problem hiding this comment.
Should this be retcode instead of ret_code?
I also don't see anything in the example return data in the examples below about the success key in the cmd.run return dicts.
There was a problem hiding this comment.
Yikes, thank you for the careful eye!
Fixed to retcode. And you're right there is no success -- I'm surprised there isn't a 1-to-1 between job returns on the CLI and on the event bus. 😕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Release notes docs.
What issues does this PR fix or reference?
#39452