-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the __utils__ dunder in Grains modules #49128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes a lot of sense. Thanks, @mirceaulinic
@mirceaulinic Hey! Are you going to backport this feature to |
Hey @max-arnold. I'd be glad to port it, but I'm very surprised this code didn't make it given that's been merged a long time ago. My understanding is that it should have been included in 2019.2.0 at least, then 2019.2.1 as well, which is what SaltStack considers as stable. So now I'm just confused how on earth this is not there yet? |
It was merged to
They explained this in more details during the office hours call on Oct 29, but I can't find the recording. Eventually they plan to port all the PRs from Neon on top of the new |
Ok, I went ahead and ported it: #55336 |
[master] Allow the __utils__ dunder in Grains modules (port #49128)
What does this PR do?
Allows having
__utils__
in Grains modules.Previous Behavior
Unable to use a custom utils module.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.