Correct win_path index checks to allow for 0 #50970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue with win_path module that improperly handled an index of 0.
Normalizes the path to allow for the example in bug report #45622. Allows the name to end with a path separator.
Fixes a win_path state comment ensuring an index of 0 is reported properly.
What issues does this PR fix or reference?
Fixes #45622
Previous Behavior
Failed to move a path from 1,2,... to 0.
New Behavior
Tests written?
Yes. Added assertion to validate adding to path at index 0.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.