Add multiple retries and timeout for getting vm resources in proxmox … #51013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't see any of the drill-down info for the tests that have failed. I'm not sure what in this merge is causing an issue. |
dwoz
approved these changes
Dec 31, 2018
Merged
|
Ported to master in #56705 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cloud. Fixes #49485
What does this PR do?
Introduces more resilient querying of VMs through the proxmox driver when trying to get the VM resources from proxmox.
What issues does this PR fix or reference?
Fixes issue #49485
Previous Behavior
After creating a VM via the proxmox API, the machine is un-named. If salt-cloud's proxmox driver queries fast enough after the creation of the VM, the resource will be returned without a name key. This causes the proxmox driver to fail (Raise an unhandled KeyError exception).
New Behavior
The API request is attempted multiple times for a certain period of time and if the proxmox API query continually fails we raise a saltcloud timeout exception instead.
Tests written?
No
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.