6922 fix network error errors #51343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now it fails, badly, when an invalid value was passed, obscuring the real problem(s). This makes it str-ify the values first. Signed-off-by: Wayne Werner <wwerner@saltstack.com>
Previously, like the debian module, this would blow up with invalid values. Now it shows the proper error message. It looks like the incorrect behavior was introduced in the commit on Wed Apr 4 18:31:00 2012 -0600 - 45aaf46 Signed-off-by: Wayne Werner <wwerner@saltstack.com>
dwoz
approved these changes
Jan 27, 2019
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 19, 2019
dwoz
added a commit
that referenced
this pull request
Nov 12, 2019
[master] Porting #51343 to master
|
Will this fix be in the next release? It does not appear to be in 2019.2.2. Any idea when that might be? |
|
@crlane this should show up in the Neon release - we've already got an RC out that you can try! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the error message producing code to actually produce the expected behavior (i.e. provide a useful error message).
It would be nice to refactor the debian_ip and rh_ip states, they have a lot of shared code, but I think it's probably fine for now to just make this fix. If I have to touch these modules again, though, I'll probably take the time to refactor out all the shared code 😛
What issues does this PR fix or reference?
#6922
Previous Behavior
Bad options produced a stack trace, whoops.
New Behavior
Bad options provide a nice helpful comment, e.g.:
Tests written?
Yes
Commits signed with GPG?
Yes