Docker login 51531 #51571
Closed
Docker login 51531 #51571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsulting Pillar. Data structure is required to only pass `docker-registries` key. Fixes saltstack#51531.
…nsulting Pillar. Data structure is required to only pass `docker-registries` key. Corrected typo in config.option call. Fixes saltstack#51531.
…nsulting Pillar. Data structure is required to only pass `docker-registries` key. Corrected typo in config.option call. Corrected grammar in docstring. Fixes saltstack#51531.
There was a problem hiding this comment.
I am not a fan of this implementation for a couple reasons:
- It drops support for using config keys ending in
-docker-registries, functionality that many users likely rely on. - It uses
config.optioninstead ofconfig.getwhich is widely used elsewhere in dockermod.py.
In truth, the reason we limited this to Pillar to begin with is because it lets you store the secrets somewhere other than the minion config file. I'm not convinced it's a great idea to store them elsewhere, but as long as it's properly documented and people are aware of the risk they are taking, I guess I'm OK with it.
However, I think it can be done in a way that doesn't break existing users' configurations. I'll see what I can come up with.
Akm0d
approved these changes
Jun 14, 2019
|
Yes that is fine with me. :)
…On Thu, Jun 20, 2019, 09:11 Megan Wilhite ***@***.***> wrote:
ping @c4t3l <https://github.com/c4t3l> are you okay closing this one in
favor of #51677 <#51677>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51571?email_source=notifications&email_token=AB4HRQ5J22JZLK247QF64EDP3OFYBA5CNFSM4GWKZTQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYFQ4YQ#issuecomment-504041058>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB4HRQ5RC3TWITT6EFE2MC3P3OFYBANCNFSM4GWKZTQQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds functionality for setting docker login info from pillar and master/minion config files.
What issues does this PR fix or reference?
References #51531
Previous Behavior
Docker login execution module only reads configuration data from Pillar.
New Behavior
Docker login execution module now reads configuration data from minion, master, and pillar.
Tests written?
No
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.