Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implemented salt.utils.path.which to properly define executable semantics on both the windows and posix platforms. #51785

Merged
merged 12 commits into from
Mar 12, 2019
Merged

Re-implemented salt.utils.path.which to properly define executable semantics on both the windows and posix platforms. #51785

merged 12 commits into from
Mar 12, 2019

Commits on Feb 23, 2019

  1. Re-implemented salt.utils.path.which to properly define executable se… 

    …mantics on both the windows and posix platforms.
    @arizvisa
    arizvisa committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    a28451f View commit details
    Browse the repository at this point in the history

  2. Removed an unused import due to the deprecation of the previous salt.… 

    …utils.path.which, and removed spaces from a set comprehension that the saltstack's linter didn't like.
    @arizvisa
    arizvisa committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    0989551 View commit details
    Browse the repository at this point in the history

  3. Fixed a bug in salt.utils.path.which when a caller hardcodes an execu… 

    …table extension.
    @arizvisa
    arizvisa committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    00f981f View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2019

  1. Added the case to salt.utils.path.which where a valid path to a binar… 

    …y can short-circuit the system_path search.
    @arizvisa
    arizvisa committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    bcfe137 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2019

  1. Fixed the unit.utils.test_path unit-tests since the original which im… 

    …plementation had an unncessary check.
    @arizvisa
    arizvisa committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    559c7a6 View commit details
    Browse the repository at this point in the history

  2. Fixed the test_path unit tests to also assign os.pathsep since the or… 

    …iginal author is assuming that ';' is being used.
    @arizvisa
    arizvisa committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    54d714c View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2019

  1. Fixed a bug in salt.utils.path.which when adding the default system p… 

    …aths in case the PATH is non-existent.
    @arizvisa
    arizvisa committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    fda866a View commit details
    Browse the repository at this point in the history

  2. Swapped the side_effects for os.access and os.path.isfile since we're… 

    … trying to simulate the existence of a file and not whether its executable or not.
    @arizvisa
    arizvisa committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    bd957bc View commit details
    Browse the repository at this point in the history

  3. Grr...forgot to add arguments to the patches used in the TestWhich un… 

    …it tests.
    @arizvisa
    arizvisa committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    8a33df1 View commit details
    Browse the repository at this point in the history

  4. Grrrrr...fixed the wrong number of parameters being patched to os.acc… 

    …ess.
    @arizvisa
    arizvisa committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    8756079 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into saltstackGH-51784

    @twangboy
    twangboy authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    fe97e5d View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. Merge branch 'develop' into saltstackGH-51784

    @twangboy
    twangboy authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    aeae914 View commit details
    Browse the repository at this point in the history