Remove hipchat engine due to service retirement #51949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethgreenaway
approved these changes
Mar 5, 2019
|
I don't think we have to do removals very often, is it worth adding a sentence into the release notes? |
|
@mchugh19 Yup. A note in the release notes about removing the engine would be a good addition. |
mchugh19
pushed a commit
to mchugh19/salt
that referenced
this pull request
Oct 13, 2019
Remove hipchat engine due to service retirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the hipchat engine
What issues does this PR fix or reference?
None, but hipchat cloud is no more.
Previous Behavior
There was hipchat, and salt worked with it.
New Behavior
No more hipchat, so salt has no one to talk to
Tests written?
No
Commits signed with GPG?
No