Add DigitalOcean DNS-01 verification to module.acme #52115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide access to `dns_plugin` `digitalocean`. Also, add `dns_plugin_propagation_seconds`.
|
@salty-vagrant It looks like this module has little to no test coverage. Can you add some basic unit or integration tests in another PR? |
dwoz
approved these changes
Mar 8, 2019
@dwoz I'll look into this as time allows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds access to the DigitalOcean
certbotplugin for DNS-01 verification.What issues does this PR fix or reference?
#52114
New Behavior
Adds
dns_plugindigitaloceanoption. Also add new kwargdns_plugin_propagation_secondsto bothdigitaloceanand existingcloudflareplugins.Tests written?
No
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.