Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop] Update to virtualenv module removing pyvenv if Python greater than 3.6 #52279

Merged
merged 7 commits into from
Mar 25, 2019
Merged

[develop] Update to virtualenv module removing pyvenv if Python greater than 3.6 #52279

merged 7 commits into from
Mar 25, 2019

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Mar 21, 2019 •
edited
Loading

What does this PR do?

Beginning in Python 3.6, pyvenv has been deprecated in favor of using venv, so remove it from the list if we are using 3.6 or higher.

What issues does this PR fix or reference?

N/A

Tests written?

No. Tests exist.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway
Beginning in Python 3.6, pyenv has been deprecated in favor of using …
b36df4a 
…venv, so remove it from the list if we are using 3.6 or higher.
@garethgreenaway garethgreenaway requested a review from a team March 21, 2019 21:11
@garethgreenaway garethgreenaway changed the title [develop] Update to virtualenv module removing pyenv if Python greater than 3.6 [WIP][develop] Update to virtualenv module removing pyenv if Python greater than 3.6 Mar 21, 2019
@garethgreenaway garethgreenaway changed the title [WIP][develop] Update to virtualenv module removing pyenv if Python greater than 3.6 [develop] Update to virtualenv module removing pyenv if Python greater than 3.6 Mar 21, 2019
@garethgreenaway garethgreenaway mentioned this pull request Mar 22, 2019
Merged
@gtmanfred
Copy link
Contributor

Can you clarify this, is pyenv deprecated or pyvenv deprecated? Because they are two separate things.

gtmanfred
gtmanfred reviewed Mar 25, 2019
View reviewed changes
Copy link
Contributor

@gtmanfred gtmanfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyenv is a tool for installing multiple full versions of python, and is not part of the stdlib

pyvenv is a binary that used to be provided by python as a replacement for virtualenv, and in python3.6 was deprecated in favor of python -m venv

salt/modules/virtualenv_mod.py Outdated Show resolved Hide resolved
@garethgreenaway garethgreenaway changed the title [develop] Update to virtualenv module removing pyenv if Python greater than 3.6 [develop] Update to virtualenv module removing pyvenv if Python greater than 3.6 Mar 25, 2019
gtmanfred
gtmanfred approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@gtmanfred gtmanfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@garethgreenaway garethgreenaway merged commit a4bda0e into saltstack:develop Mar 25, 2019
@Ch3LL Ch3LL mentioned this pull request Jun 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtmanfred gtmanfred gtmanfred approved these changes

@twangboy twangboy twangboy approved these changes

Assignees
No one assigned
Labels
code-jam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garethgreenaway @gtmanfred @twangboy @sagetherage