-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: support slot parsing inside dict and lists of dict or strings #52351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryKuzmenko
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this code.
@thatch45 could you please take a look at this? |
Tests added |
thatch45
approved these changes
Apr 8, 2019
For the record, this is fantastic and I wanted to get it in when I added slots but I just did not have the time. Is there anything blocking merging this? |
mchugh19
pushed a commit
to mchugh19/salt
that referenced
this pull request
Oct 13, 2019
Draft: support slot parsing inside dict and lists of dict or strings
max-arnold
added a commit
to max-arnold/salt
that referenced
this pull request
Dec 19, 2019
max-arnold
added a commit
to max-arnold/salt
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for parsing slots inside of dictionaries and dicts and strings inside of lists.
This enables slot support for subkeys
What issues does this PR fix or reference?
#51798
#50596
Previous Behavior
As mentioned in linked issues, slots were not parsed in subkeys of state files
The following states displays the slot text itself
New Behavior
Previously mentioned state examples now show slot results
Tests written?
Yes
Commits signed with GPG?
No
@DmitryKuzmenko