Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds windows event log support #53700

Merged
merged 25 commits into from
Jul 8, 2019
Merged

Conversation

cmcmarrow
Copy link
Contributor

@cmcmarrow cmcmarrow commented Jul 3, 2019

What does this PR do?

adds windows event log support

saltstack/community#33

Tests written?

Yes

Commits signed with GPG?

Yes

Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, though I've got some potential changes/questions.

salt/modules/win_event_viewer.py Outdated Show resolved Hide resolved
salt/modules/win_event_viewer.py Outdated Show resolved Hide resolved
salt/modules/win_event_viewer.py Outdated Show resolved Hide resolved
salt/modules/win_event_viewer.py Show resolved Hide resolved
salt/modules/win_event_viewer.py Show resolved Hide resolved
salt/modules/win_event_viewer.py Show resolved Hide resolved
salt/modules/win_event_viewer.py Show resolved Hide resolved
@cmcmarrow cmcmarrow requested a review from waynew July 3, 2019 16:47
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close!

salt/modules/win_event_viewer.py Outdated Show resolved Hide resolved
salt/modules/win_event_viewer.py Outdated Show resolved Hide resolved
salt/modules/win_event_viewer.py Outdated Show resolved Hide resolved
Copy link
Contributor

@garethgreenaway garethgreenaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gives SaltStack access to Windows event log
:codeauthor: Charles McMarrow <cmcmarrow@saltstack.com>

salt/modules/win_event_viewer.py Outdated Show resolved Hide resolved
@cmcmarrow cmcmarrow merged commit e3956ba into saltstack:develop Jul 8, 2019
@sagetherage sagetherage added the has master-port port to master has been created label Apr 23, 2020
@twangboy twangboy added master-port and removed has master-port port to master has been created labels Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants